Skip to content

Conversation

@yelhouti
Copy link
Contributor

remove leading space

PR checklist

Read the contribution guidelines.
[no need] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows.
[Master] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09)
Description of the PR

fix the config variable names in order to remove the leading space that makes the cinfig unusable (at least in properties.yml) it's done the same way in API Client

@cbornet
Copy link
Contributor

cbornet commented Nov 29, 2017

@yelhouti can you generate the sample ?

@yelhouti
Copy link
Contributor Author

yelhouti commented Nov 29, 2017

it won't change a thing since no basicAuth config is defined, no?

@wing328
Copy link
Contributor

wing328 commented Nov 29, 2017

I did a simple test and there is a minor change to the sample as follows:

--- a/samples/client/petstore/spring-cloud/src/main/java/io/swagger/configuration/ClientConfiguration.java
+++ b/samples/client/petstore/spring-cloud/src/main/java/io/swagger/configuration/ClientConfiguration.java
@@ -22,7 +22,7 @@ import org.springframework.security.oauth2.common.exceptions.OAuth2Exception;
 @EnableConfigurationProperties
 public class ClientConfiguration {
 
-  @Value("${ swaggerPetstore.security.apiKey.key:}")
+  @Value("${swaggerPetstore.security.apiKey.key:}")
   private String apiKeyKey;

I'll update the samples after merging it into master.

Next time please run ./bin/spring-all-pestore.sh (or corresponding batch file under .\bin\windows) to update the samples.

@wing328 wing328 merged commit ce11e03 into swagger-api:master Nov 29, 2017
@wing328
Copy link
Contributor

wing328 commented Nov 29, 2017

Samples updated via 80cc90c

@yelhouti
Copy link
Contributor Author

my bad, thank you guys for the info and the help, good luck with this great lib

@wing328
Copy link
Contributor

wing328 commented Nov 29, 2017

@yelhouti no problem. Thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants