Skip to content

Conversation

@JFCote
Copy link
Contributor

@JFCote JFCote commented Dec 5, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09)

Description of the PR

Add the readme.md that I think was removed when I've done the refactoring a couple of months ago.

Copy link
Contributor

@TiFu TiFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please review the comments I added.


### Publishing

First build the package than run ```npm publish```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think than should be then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I did a copy paste from another readme.mustache so I didn't check for error like this. Will fix in my next commit. Thanks


### Consuming

navigate to the folder of your consuming project and run one of next commando's.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commands? (without apostrophe and o)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix in my next commit

@JFCote
Copy link
Contributor Author

JFCote commented Dec 5, 2017

@TiFu The fix is done!

@wing328 wing328 merged commit 40f1de8 into swagger-api:master Dec 6, 2017
@JFCote JFCote deleted the add-readme-jquery-client branch December 21, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants