-
Notifications
You must be signed in to change notification settings - Fork 6k
[Typescript jQuery] Add README.md #7113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typescript jQuery] Add README.md #7113
Conversation
TiFu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Please review the comments I added.
|
|
||
| ### Publishing | ||
|
|
||
| First build the package than run ```npm publish``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think than should be then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I did a copy paste from another readme.mustache so I didn't check for error like this. Will fix in my next commit. Thanks
|
|
||
| ### Consuming | ||
|
|
||
| navigate to the folder of your consuming project and run one of next commando's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commands? (without apostrophe and o)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix in my next commit
…n fetch too since it was a copy paste
|
@TiFu The fix is done! |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09)
Description of the PR
Add the readme.md that I think was removed when I've done the refactoring a couple of months ago.