Skip to content

Conversation

@knom
Copy link
Contributor

@knom knom commented Dec 5, 2017

@jimschubert, @mandrean, @wing328

Somehow related to #2886, but for the SERVER
Moved the project structure, mustache files, .. to ASP.NET Core 2.0.

Let me know what you think!

@jimschubert
Copy link
Contributor

This looks good, but should probably go into 2.3.0. I can't see the target branch on mobile.

@wing328
Copy link
Contributor

wing328 commented Dec 5, 2017

@jimschubert it's targeting current master (which is 2.3.0)

@wing328
Copy link
Contributor

wing328 commented Dec 5, 2017

@knom if I understand correctly, we'll no longer support ASP.NET CORE 1.0 after merging this PR into master so I've marked this PR as a "Breaking Change" (without fallback).

@knom
Copy link
Contributor Author

knom commented Dec 5, 2017

@wing328 that is right!
There's three changes..

@jimschubert
Copy link
Contributor

@wing328 Thanks. I haven't looked at the version in master in a while, I didn't realize it was promoted to 2.3.0. I didn't check the compile to verify, but @knom has been making quality contributions and I don't see any reason it would not work as expected.

@wing328 wing328 merged commit e75523a into swagger-api:master Dec 6, 2017
@knom knom deleted the aspnetcore2 branch December 6, 2017 17:49
@knom
Copy link
Contributor Author

knom commented Dec 12, 2017

Thanks for the quick merge :-)

@wing328 wing328 changed the title [AspNetCore SERVER] Added support for ASP.NET Core 2.0 [ASP.NET Core] Added support for ASP.NET Core 2.0 Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants