Skip to content

Conversation

@ehyche
Copy link
Contributor

@ehyche ehyche commented Jan 2, 2018

PR checklist

  • [x ] Read the contribution guidelines.
  • [x ] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [x ] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [x ] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

There was a previous issue (#6919) and subsequent PR (#6952) to add "throw" to the list of reserved words for Swift 4.

I decided it would be helpful to group the Swift4 reserved words into groups that we can check against future revisions of swift. For each group, I provided a reference link so that we can check in the future if new reserved words have been added. I verified that all of the current reserved words are included somewhere in the new groupings. The groups are:

  • Reserved words specifically called out in the Swift 4 Language Reference (link provided in the source)
  • Reserved words from the Swift Standard Library (link provided in the reference)
  • Objective-C compatibility types
  • Commonly-used Foundation types
  • Others

@ehyche
Copy link
Contributor Author

ehyche commented Jan 2, 2018

@jgavris @Edubits @jaz-ah : please review

@wing328 wing328 closed this Jan 3, 2018
@wing328 wing328 reopened this Jan 3, 2018
@wing328 wing328 changed the base branch from master to 2.4.0 January 7, 2018 03:23
@wing328
Copy link
Contributor

wing328 commented Jan 7, 2018

@ehyche when you've time, can you please update the following test as id has been added to the list in this PR?

Results :

Failed tests: 
  Swift4ModelTest.simpleModelTest:42 expected [id] but found [_id]

Tests run: 544, Failures: 1, Errors: 0, Skipped: 3

@wing328 wing328 merged commit 6c6cf1c into swagger-api:2.4.0 Jan 7, 2018
@wing328
Copy link
Contributor

wing328 commented Jan 7, 2018

@ehyche no worry I've fixed the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants