Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop 2.0 #868

Closed
wants to merge 9 commits into from
Closed

Conversation

boazsapir
Copy link

See my proposed spec OAI/OpenAPI-Specification#50

This is the implementation of the proposed spec update, as detailed in the above mentioned swagger-spec issue #50, to support binary input and output.
Dependency: swagger-api/swagger-core#1166

b_sapir added 6 commits May 20, 2015 14:39
…t octet-stream

- rearrange invokeAPI functions to support binary
- add tests for binary data
Conflicts:
	modules/swagger-codegen/src/main/java/com/wordnik/swagger/codegen/CodegenOperation.java
	modules/swagger-codegen/src/main/java/com/wordnik/swagger/codegen/DefaultCodegen.java
	modules/swagger-codegen/src/main/java/com/wordnik/swagger/codegen/languages/JavaClientCodegen.java
	modules/swagger-codegen/src/main/resources/Java/api.mustache
	modules/swagger-codegen/src/main/resources/Java/apiInvoker.mustache
	pom.xml
@wing328
Copy link
Contributor

wing328 commented Jun 15, 2015

@boazsapir FYI. The CI build failed with the following error message:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.0:compile (default-compile) on project swagger-codegen: Compilation failure: Compilation failure:
[ERROR] /home/travis/build/swagger-api/swagger-codegen/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java:[29,36] cannot find symbol
[ERROR] symbol:   class ByteArrayProperty
[ERROR] location: package io.swagger.models.properties
[ERROR] /home/travis/build/swagger-api/swagger-codegen/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java:[448,33] cannot find symbol
[ERROR] symbol:   class ByteArrayProperty
[ERROR] location: class io.swagger.codegen.DefaultCodegen

@boazsapir
Copy link
Author

The failure its because of the dependency on swagger-api/swagger-core#1166
This one can be built only after 1166 is merged

b_sapir added 3 commits August 6, 2015 20:10
Conflicts:
	modules/swagger-codegen/src/main/resources/Java/ApiClient.mustache
	modules/swagger-codegen/src/main/resources/Java/api.mustache
…o the agreed spec (use "binary" format rather than "byte" for binary arrays)

- Some code changes as a result of the merge with the latest upstream code
- in the generated java code: do not do html encryption of the URL
…d in the final implementation of support for binary arrays
@boazsapir boazsapir closed this Aug 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants