URL parameters in GET request would not ge properly url-encoded #9387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ sign would not get encoded, but decoded, resulting in a space, which in turn resulted in invalid parameters on the server side
pakaufmann
force-pushed
the
fix-url-encoding-for-resttemplate
branch
3 times, most recently
from
9c58e19 to
3a3e011
Compare
|
Ok, so apparently this cannot be achieved in Sprint 4.3.9 (or any Spring 4 version for that matter). So, can the Rest-Template be updated to Spring 5? Or is this not wanted, as it should work with Spring 4? |
pakaufmann
force-pushed
the
fix-url-encoding-for-resttemplate
branch
4 times, most recently
from
d8a87c2 to
cad68cd
Compare
pakaufmann
force-pushed
the
fix-url-encoding-for-resttemplate
branch
from
cad68cd to
e64fc11
Compare
|
So, instead of trying to make it backwards-compatible I added a new config-parameter "spring5". If activated it generates the demo client with spring5, which then fixes the bug there. Per default it is deactivated in order to stay backwards compatible. |
|
Hey guys, |
|
Why is this fix after 5 years still not merged? Who can merge this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The + sign would not get encoded, but decoded, resulting in a space, which in turn resulted in invalid parameters on the server side.
This should fix this issue #7747.
As the encode() in RestTemplate only works when using expanded variables (spring-projects/spring-framework#21577), instead of directly adding the parameters to the queryParams, this creates variables which are expanded for all inputted query params.