[Issue 9685] Make RestTemplate thread safe by using the withHttpInfo pattern used … #9737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…by many other generated clients
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.Description of the PR
This PR is to make the generated RestTemplate client thread safe. Currently, we don't have any way of retrieving the response headers except by using
getResponseHeaders()
method which returns the latest response headers, in the case multiple threads use the ApiClient we might end up getting the headers of the response sent to another thread.This PR purpose is to add an additional method which not only return the expected DTO but also the
ResponseEntity
wrapping it, so user can easily retrieve headers by inspecting theResponseEntity
. The usual methods to directly get the DTO are conserved.This change breaks backward compatibility since (thread unsafe) attributes,
statusCode
andresponseHeaders
, are removed from ApiClient class.Fixes: #9685, #9222
PR mostly inspired by @tsiq-karold work on Jersey2 (#7605), and
withHttpInfo
pattern used in other generated clients.