Bugfix/2098 allows null values when nullable

src/plugins/validate-semantic/validators/2and3/schemas.js

@@ -23,18 +23,24 @@ export const validate2And3TypeArrayRequiresItems = () => (system) => {
     })
 }
 
+
+
 export const validate2And3TypesInDefaultValuesMatchesWithEnum = () => (system) => {
   return system.validateSelectors
     .allSchemas()
     .then(nodes => {
       return nodes.reduce((acc, node) => {
         const schemaObj = node.node
         const { type } = schemaObj || {}
+        const isNullable = !!schemaObj.nullable
         const enumeration = schemaObj.enum
         if (enumeration !== null && typeof enumeration !== "undefined") {
           var enumIndex = 0
           enumeration.forEach((element, index) => {
             var isValidFormat = true
+            if (element === null && isNullable) {
+              return
+            }
             if (type === "array" && (!Array.isArray(element) || element === null)) {
               isValidFormat = false
               enumIndex = index
@@ -55,9 +61,10 @@ export const validate2And3TypesInDefaultValuesMatchesWithEnum = () => (system) =
                 level: "warning",
               })
             }
+
           }) 
         }
         return acc
       }, [])
     })
-}
+}

test/unit/plugins/validate-semantic/2and3/schemas.js

@@ -514,4 +514,33 @@ describe(`values in Enum must be instance of the defined type`, () => {
       expect(allErrors.length).toEqual(0)
     })
   })
+
+  it("should not return an error for a null value in a enum object when nullable is true type in OpenApi 3", () => {
+    const spec = {
+      openapi: "3.0.0",
+      "paths": {
+        "/pets": {
+          "get": {
+            "parameters": [
+              {
+                name: "objectSample",
+                in: "query",
+                schema: {
+                  type: "object",
+                  nullable: true,
+                  enum: [null]
+                }
+              },
+            ]
+          }
+        }
+      }
+    }
+
+    return validateHelper(spec)
+    .then(system => {
+      const allErrors = system.errSelectors.allErrors().toJS()
+      expect(allErrors.length).toEqual(0)
+    })
+  })
 })