Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues with allowReserved #1181

Merged

Conversation

shockey
Copy link
Contributor

@shockey shockey commented Nov 10, 2017

Description

This PR covers some missed cases for considering OAS 3.0's Parameter.allowReserved, and adds tests for the same.

Motivation and Context

Fixes swagger-api/swagger-ui#3817.

How Has This Been Tested?

  • I added new tests 😄

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shockey shockey force-pushed the bug/3817-query-allowreserved-encoding branch from 3d1004b to c469ad7 Compare November 10, 2017 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query parameters with allowReserved=false not percent-encoded during OAS3 "Try It Out"
1 participant