Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oas2 collectionFormat when not 'multi' #1550

Merged
merged 1 commit into from
May 28, 2020

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented May 26, 2020

Description

Fix OAS2 collectionFormat handling for non-multipart cases

collectionFormat: csv
collectionFormat: tsv
collectionFormat: ssv
collectionFormat: pipes

Motivation and Context

Previous OAS2 multipart fixes did not cover non-multi cases.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tim-lai tim-lai requested a review from char0n May 26, 2020 23:19
test/http-multipart.js Outdated Show resolved Hide resolved
@tim-lai tim-lai force-pushed the fix/oas2-collectionformat branch from d3f144f to 16520ee Compare May 27, 2020 16:21
src/http.js Outdated Show resolved Hide resolved
* reorganize http-multipart tests
* simplify negation in 'buildFormData'
@tim-lai tim-lai force-pushed the fix/oas2-collectionformat branch from 16520ee to 8bb5ec8 Compare May 27, 2020 18:28
@tim-lai tim-lai merged commit b023192 into swagger-api:master May 28, 2020
@tim-lai tim-lai deleted the fix/oas2-collectionformat branch June 5, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants