Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(http-client): document request cancellation via AbortSignal #1727

Merged
merged 1 commit into from
Sep 21, 2020
Merged

docs(http-client): document request cancellation via AbortSignal #1727

merged 1 commit into from
Sep 21, 2020

Conversation

char0n
Copy link
Member

@char0n char0n commented Sep 21, 2020 •
edited
Loading

Refs #1254

Motivation and Context

Timeouts and request cancellation are requirements that are frequently needed. This PR
add documentation about how to achieve both.

How Has This Been Tested?

All examples have been manually tested.

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@char0n char0n self-assigned this Sep 21, 2020
@char0n char0n mentioned this pull request Sep 21, 2020
Closed
10 tasks
@char0n
Copy link
Member Author

char0n commented Sep 21, 2020

Thanks @tim-lai

@char0n char0n merged commit 3554539 into master Sep 21, 2020
@char0n char0n deleted the char0n/cancelling-requests-docs branch October 2, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-lai tim-lai tim-lai approved these changes

@webron webron Awaiting requested review from webron

Assignees

@char0n char0n

Labels
cat: documentation type: enhancement version: 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@char0n @tim-lai