This repository was archived by the owner on Sep 14, 2022. It is now read-only.
Support custom host and port for editor #219
Merged
+48
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Thanks, @joostfarla! |
theganyo
added a commit
that referenced
this pull request
Jun 11, 2015
Support custom host and port for editor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swagger editor (when using the Swagger CLI) is normally served from host "127.0.0.1" on a port which is randomly determined when the command is executed. This approach assumes that the browser is running on the same machine as the Swagger process.
In my case, I'm running Node.js and Swagger from within a Vagrant VM and Vagrant requires to define a set of specific ports which will be forwarded from the host (where the browser is running on) to the VM. So, to be able to access the editor from the browser, it is required to set a custom host and port to serve the Swagger editor from.
I've provided a PR including some tests.
This request is related to #210.