Skip to content
This repository was archived by the owner on Sep 14, 2022. It is now read-only.

update all skeletons to latest versions and fix async test race-condition #489

Merged
merged 5 commits into from
Apr 25, 2017

Conversation

micmro
Copy link
Contributor

@micmro micmro commented Apr 5, 2017

I've updated all 'connect'-based framework dependencies to their latest versions (inc. swagger-node-runner v0.7.0 wrapper):

  • expess
  • connect
  • hapi
  • restify

added swagger_params_parser to fix swagger-node-runner >=0.6.0 for Sway

To test this I manually copied the project-skeletons files into generated projects and ran tests and a manual run.

This will close e.g. #416

@micmro
Copy link
Contributor Author

micmro commented Apr 6, 2017

It seem like something seems to be wrong with the sails test and the connect tests - if I remove the sails test it succeeds and if I remove the connect tests as well. There seems to be some cross-dependency.

Do you have any suggestion for fixes?

@micmro
Copy link
Contributor Author

micmro commented Apr 12, 2017

Hi @fehguy, would you have any suggestions regarding the failing tests? I can't figure out why thy would fail in this pattern.

@micmro micmro force-pushed the master branch 2 times, most recently from 788ff6d to 570ffb8 Compare April 15, 2017 09:06
@micmro
Copy link
Contributor Author

micmro commented Apr 15, 2017

Also updated the Sails skeleton to the latest version of Sails (used the CLI tool to create a sails app and copied the files over) - sorry this resulted in a lot of changed files, but a lot is just comments.

I finally managed to fix the test for the latest stable node, but it looks the latest hapi few version (10.0 - 16.1.1) do not support node 0.12 anymore (needs node >=4.5.0 for the latest version).

I've reverted hapi back to 9.5.1 for now, or do you have any plans to change the test runners?

@micmro micmro changed the title update all 'connect'-based frameworks to latest versions update all skeletons to latest versions and fix async test race-condition Apr 15, 2017
@fehguy
Copy link
Contributor

fehguy commented Apr 17, 2017

Hi @micmro I think we should update the tested support to be minimum 4.x. If you want to update the travis file we can merge it. Thanks again!

@micmro
Copy link
Contributor Author

micmro commented Apr 17, 2017

Ok updated it. Is it possible to create a release for this?

@micmro
Copy link
Contributor Author

micmro commented Apr 25, 2017

Hi @fehguy I've made the changes to the travis file. Are there any other blocker for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants