-
Notifications
You must be signed in to change notification settings - Fork 584
update all skeletons to latest versions and fix async test race-condition #489
Conversation
It seem like something seems to be wrong with the sails test and the connect tests - if I remove the sails test it succeeds and if I remove the connect tests as well. There seems to be some cross-dependency. Do you have any suggestion for fixes? |
Hi @fehguy, would you have any suggestions regarding the failing tests? I can't figure out why thy would fail in this pattern. |
788ff6d
to
570ffb8
Compare
Also updated the Sails skeleton to the latest version of Sails (used the CLI tool to create a sails app and copied the files over) - sorry this resulted in a lot of changed files, but a lot is just comments. I finally managed to fix the test for the latest stable node, but it looks the latest hapi few version ( I've reverted hapi back to |
…ert hapi to 9.5.1
Hi @micmro I think we should update the tested support to be minimum 4.x. If you want to update the travis file we can merge it. Thanks again! |
Ok updated it. Is it possible to create a release for this? |
Hi @fehguy I've made the changes to the travis file. Are there any other blocker for this? |
I've updated all 'connect'-based framework dependencies to their latest versions (inc.
swagger-node-runner
v0.7.0 wrapper):added
swagger_params_parser
to fixswagger-node-runner
>=0.6.0 for SwayTo test this I manually copied the
project-skeletons
files into generated projects and ran tests and a manual run.This will close e.g. #416