Fix issue that "void" response is treated as model #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when converting spec from v1.2 to v2.0
fehguy
added a commit
that referenced
this pull request
Apr 3, 2015
Fix issue that "void" response is treated as model
mwgray
added a commit
to mwgray/swagger-codegen
that referenced
this pull request
Sep 21, 2016
There was a lot of issues with this function that deemed it ready for cleanup: 1. There's was a lot of copy paste code with error handling and data parsing, just to do a little bit of distinct code. It is significantly cleaner now, and the important code is only 1-2 lines a piece. It's much easier to see what the code is doing in each case. 2. There was very old code for handling lack of swagger supporting void from 2015: swagger-api/swagger-parser#34. This code was rather confusing `if () is T` and `if "" is T` both seemed to handling the Void case, which was apparantly added a while back. 3. Instead of calling Alamofire's helper functions for response parsing(`responseString` & `responseJSON`) which just delegate to Serializer, the general one(`response`) is now called and the serializer is selected based on the <T> parameter. String & default(JSON) were the affected cases.
mwgray
added a commit
to mwgray/swagger-codegen
that referenced
this pull request
Sep 22, 2016
There was a lot of issues with this function that deemed it ready for cleanup: 1. There's was a lot of copy paste code with error handling and data parsing, just to do a little bit of distinct code. It is significantly cleaner now, and the important code is only 1-2 lines a piece. It's much easier to see what the code is doing in each case. 2. There was very old code for handling lack of swagger supporting void from 2015: swagger-api/swagger-parser#34. This code was rather confusing `if () is T` and `if "" is T` both seemed to handling the Void case, which was apparantly added a while back. 3. Instead of calling Alamofire's helper functions for response parsing(`responseString` & `responseJSON`) which just delegate to Serializer, the general one(`response`) is now called and the serializer is selected based on the <T> parameter. String & default(JSON) were the affected cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue that "void" response is treated as model when converting spec from v1.2 to v2.0.
See more at swagger-api/swagger-codegen#305