Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support an optional client secret in token request #1324

Closed
yonderblue opened this issue Jun 1, 2015 · 0 comments
Closed

Support an optional client secret in token request #1324

yonderblue opened this issue Jun 1, 2015 · 0 comments
Milestone

Comments

@yonderblue
Copy link

This is a feature request but I'm not sure I got the right repo. If I have time i'll put a pull request in as the little hack I have seems to work.

Basically in swagger-oauth.js adding the line clientSecret = (o.clientSecret||errors.push('missing client secret')); or something to that effect in the initOAuth() function and then 'client_secret': clientSecret, to the params in the processOAuthCode() function should allow client secret to pass to the oauth server's token endpoint.

The current github and google api just to name two require it. But I imagine it should be optional as its not part of the oauth spec. Thanks !

@webron webron added this to the v2.1.2 milestone Jul 21, 2015
fehguy added a commit that referenced this issue Jul 23, 2015
Add support for oauth client secret when calling the token URL. Fixes #1384. Fixes #1324.
@fehguy fehguy closed this as completed in 1fd15c6 Jul 23, 2015
@webron webron modified the milestones: v2.1.1, v2.1.2 Jul 31, 2015
vincent-zurczak pushed a commit to roboconf/swagger-ui that referenced this issue Aug 19, 2016
Add support for oauth client secret when calling the token URL. Fixes swagger-api#1384. Fixes swagger-api#1324.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants