swagger-config.yaml configuration is overriden by the defaults

[segevfiner]

Q&A (please complete the following information)

• OS: Windows 10.0.17763.253 x64
• Browser: Firefox
• Version: 64.0.2
• Method of installation: npm run dev
• Swagger-UI version: abf3496
• Swagger/OpenAPI version: any

Describe the bug you're encountering

swagger-config.yaml is being overriden by default configuration:

swagger-ui/src/core/index.js

Line 136 in 455ec3d

let mergedConfig = deepExtend({}, localConfig, constructorConfig, fetchedConfig || {}, queryConfig)

constructorConfig is filled with the defaults.

To reproduce...

Steps to reproduce the behavior:

1. Change anything in swagger-config.yaml and check ui.getSystem().getConfigs().

Expected behavior

swagger-config.yaml changes the defaults but is overridden by other config mechanisms.

[shockey]

Fair point.

Once upon a time, swagger-config.yaml was the place for our defaults, but we slipped into index.js over time.

Would be happy to see a PR that solves this!

[char0n]

@glowcloud please remove the system config option source.

[char0n]

We have to be cautious about that fact that using swagger-config.yaml is part of core/plugins/config. Part of this issue is to also determine what part of this plugin we can remove (ideally entire plugin) and remove it.

[char0n]

Related to #9818

[char0n]

Update: cannot remove entire configs plugin, only parts of it.

[char0n]

Addressed in #9875