BUG: "Copy" button not working

[Teraskull]

The "Copy" button does not work anymore since commit f3ea2a2

Verified by running SwaggerUI on the previous commit: be9f944
The "Copy" button works as intended here.

[Teraskull]

@damian-polewski-sb Can you please verify if your commit is the issue here?

[Teraskull]

Found a fix.

Replace this:

swagger-ui/src/core/components/copy-to-clipboard-btn.jsx

Lines 17 to 21 in 4b0e8a8

	<div className="view-line-link copy-to-clipboard" title="Copy to clipboard">
	<CopyToClipboard text={this.props.textToCopy}>
	<CopyIcon />
	</CopyToClipboard>
	</div>

with:

<CopyToClipboard text={this.props.textToCopy}>
  <div className="view-line-link copy-to-clipboard" title="Copy to clipboard">
    <CopyIcon />
  </div>
</CopyToClipboard>

[damian-polewski-sb]

Hi @Teraskull,
I tested it now and it looks like wrapping svg for copy icon with React functional component in this PR caused an issue with CopyToClipboard wrapping component.

As you suggested, wrapping the whole div in CopyToClipboard solves this issue. I will be raising a PR to apply those changes.

Thanks for your help!

[char0n]

Hi everybody,

Thank you for reporting this issue and providing a possible remediation.

I've issued #9106 which superseded #9097.

This issue suggests a solution (which works), but underlying systemic issue wouldn't been addressed. The solution proposed in this issue lacks explanation so we're not sure why it works. If we dig deeper we find out that our new icons plugin SVG components lacks ability to pass arbitrary props, which inhibits it from handling React element native events - like onClick event used by react-copy-to-clipboard. By wrapping SVG icon component into <div> solves this issue as <div> allows arbitrary props passing. But applying this fix is not a solution that addresses the systemic problem, but rather a ad-hoc remediation. Another issues would probably pop up soon.

[damian-polewski-sb]

Hi @char0n! First of all, nice job! I agree this approach will be much more elegant and will get rid of any further issues with arbitrary props that might come up.
Thanks!

[char0n]

Addressed in #9106