Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show deprecated operations strikethrough #1740

Merged
merged 2 commits into from
Nov 12, 2015
Merged

Conversation

jkoepcke
Copy link
Contributor

No description provided.

@iamcrunch
Copy link

Interesting. I added this in 20c5553, but it was removed in b0301d6.

fehguy added a commit that referenced this pull request Nov 12, 2015
Show deprecated operations strikethrough
@fehguy fehguy merged commit 257db60 into swagger-api:master Nov 12, 2015
brentonmcs pushed a commit to brentonmcs/swagger-ui that referenced this pull request Nov 20, 2015
Show deprecated operations strikethrough
@fehguy fehguy modified the milestone: v2.1.4 Jan 6, 2016
@nickcmaynard
Copy link

Despite being merged, this change is missing in master and tag v2.1.4.

@fehguy
Copy link
Contributor

fehguy commented Jan 26, 2016

Looks like it works to me:

image

{
  "swagger": "2.0",
  "info": {
    "version": "1.0.0",
    "title": "This is a demo api",
    "description": "Hope you enjoy it!"
  },
  "paths": {
    "/hello": {
      "get": {
        "deprecated": true,
        "description": "it's a simple test",
        "parameters": [
          {
            "in": "query",
            "name": "username",
            "type": "string",
            "required": false
          }
        ],
        "responses": {
          "200": {
            "description": "it worked",
            "schema": {
              "$ref": "#/definitions/SuccessResponse"
            }
          }
        }
      }
    }
  },
  "definitions": {
    "SuccessResponse": {
      "properties": {
        "code": {
          "type": "integer",
          "format": "int32"
        }
      }
    }
  }
}

@nickcmaynard
Copy link

This patch added strikethrough styling to the operation name. That doesn't happen. Indeed, the CSS alterations present in this patch are not present in either screen.css or print.css.

screen shot 2016-01-26 at 21 43 02

@fehguy
Copy link
Contributor

fehguy commented Jan 26, 2016

ok i'm happy to reapply a PR if you can send it.

@nickcmaynard
Copy link

See #1924. Looks like the reason we lost this is that the changes were only made to generated files. If not already in the CONTRIBUTING guidelines, suggest addition.

vincent-zurczak pushed a commit to roboconf/swagger-ui that referenced this pull request Aug 19, 2016
Show deprecated operations strikethrough
@ningyougang
Copy link

Support deparecated just on a filed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants