Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Add the start command to package.json #4572

Merged
merged 1 commit into from
May 22, 2018
Merged

feat : Add the start command to package.json #4572

merged 1 commit into from
May 22, 2018

Conversation

rishacha
Copy link

@rishacha rishacha commented May 19, 2018

CHANGELOG:

  1. Added start command to package.json
  2. Assign server port to 3002.

Ref : Github issue #4551

Description

Added npm run start command identical to swagger-editor.

Motivation and Context

This is to make the swagger-ui identical to the swagger.
This PR fixes #4551

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Review

@shockey

CHANGELOG:

1. Added `start` command to `package.json`
2. Assign server port to `3002`.

Ref : Github issue #4551
@shockey shockey merged commit 6b3aba6 into swagger-api:master May 22, 2018
@shockey
Copy link
Contributor

shockey commented May 22, 2018

Thanks @rishacha!

@rishacha rishacha deleted the ft/4551-add-start-to-package-json branch May 22, 2018 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hello,How to run swagger-ui
2 participants