Fix TypeError with param type #458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using || operation with "" || undefined returns undefined. Should add an additional || to end the expression with a "" to protect against the value becoming undefined and breaking the .toLowerCase() call on line 79
|
That will make it more robust, but of course, something is quite wrong to get you in this position. There should always be a |
|
True, however the JSON was produced by swagger-core running on annotations on source code. I did soon after fix the root cause. However when it was failing, swagger-ui just failed silently which seems like poor behavior requiring debugging of the javascript. Ideally somewhere along the way from the annotations there would either be an error/warning or it wouldn't fail silently. |
vincent-zurczak
pushed a commit
to roboconf/swagger-ui
that referenced
this pull request
Aug 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using || operation with "" || undefined returns undefined. Should add an additional || to end the expression with a "" to protect against the value becoming undefined and breaking the .toLowerCase() call on line 79