fix: curl entries array support within multipart/form-data (#3838) #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ft: utils.createObjWithHashedKeys ft: curlify.extractKey test: curlify with array representation
tim-lai
changed the title
|
please build |
|
the ability to actually choose files is now broken:
|
Pentusha
added a commit
to Pentusha/swagger-ui
that referenced
this pull request
May 27, 2020
* 'master' of github.com:swagger-api/swagger-ui: (37 commits) release: v3.25.4 chore(package): bump swagger-client to 3.10.4 version fix: entries as property name (swagger-api#6025) release: v3.25.3 housekeeping: update release-it config (swagger-api#6009) housekeeping: bump swagger-client version with package-lock (swagger-api#6008) housekeeping: update dev-e2e-cypress-open script name (swagger-api#6005) fix: jsonSchemaComponent file/files (swagger-api#5997) (swagger-api#6000) fix: curl array support within multipart/form-data (swagger-api#3838) (swagger-api#5999) release: v3.25.2 bug: remove clearValidation from onTryoutClick (swagger-api#5955) ft: JsonSchema components are now ImmutableJS compliant (swagger-api#5952) release: v3.25.1 housekeeping: revert @release-it/conventional-changelog version (swagger-api#5976) housekeeping: add missing conventional-changelog devDeps (swagger-api#5975) docs: update plugin api component for failSilently (swagger-api#5953) housekeeping: `npm audit fix` (swagger-api#5948) housekeeping: prevent log warning for missing getComponent in production fix(docker-image): send relative HTTP 301s from within container (swagger-api#5409) support for supportedSubmitMethods property in react component (swagger-api#5376) ...
#6040 this fix the choose file for array items |
mattyb678
pushed a commit
to mattyb678/swagger-ui
that referenced
this pull request
Jun 24, 2020
…swagger-api#5999) ft: utils.createObjWithHashedKeys ft: curlify.extractKey test: curlify with array representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a. Immutable's OrderedMap does not support duplicate keynames, and will overwrite with new value(s)
b. We now create an object, if multiple, where a hashIndex is appended to the original keyname, along with a counter
c. If multiple, the original key name (without hashIndex) is deleted
d. This object is returned and used to change state for spec.mutatedRequest
e. curlify.js is modified to check for presence of hashIndex, and is able to extract the original key name to push into its return array (to join into String)
Motivation and Context
Fixes #3838
How Has This Been Tested?
New test added to verify handling of
hashIdxScreenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests