Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up syntax highlighting of code section - Configuration fix for Examples #6455

Conversation

AdrieanKhisbe
Copy link
Contributor

Description

Complement #5259, getConfigs was not correctly forwarded to Examples πŸ–‡οΈ
As a result, syntax highlight could not be disabled be disabled or configured in that element as was reported by @mariem-89

Motivation and Context

Achieve expected behavior introduced in #5259

How Has This Been Tested?

Ran the test locally and performed local acceptance tests (see screenshots)

Screenshots (if appropriate):

Before / After

Capture d’écran 2020-10-02 aΜ€ 01 21 09

Capture d’écran 2020-10-02 aΜ€ 01 20 57

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

…o Examples πŸ”Œ

As a result, syntax highlight could not be disabled be disabled or configured in that elements
@AdrieanKhisbe AdrieanKhisbe force-pushed the ft/setting-up-syntax-highlighting-tweakings branch from 8239009 to 615a882 Compare October 1, 2020 23:31
@AdrieanKhisbe
Copy link
Contributor Author

πŸ”„ (rebased on top on up to date master, and fixed typo in commit message)

@tim-lai tim-lai merged commit b5e8081 into swagger-api:master Oct 2, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Oct 2, 2020

@AdrieanKhisbe Thanks for the followup fix!

@AdrieanKhisbe
Copy link
Contributor Author

You're welcome @tim-lai :)
Thanks for you too for your reactivity!! πŸ™‚

@AdrieanKhisbe AdrieanKhisbe deleted the ft/setting-up-syntax-highlighting-tweakings branch October 2, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants