-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sample gen should incorporate schema validation constraint #7043
Merged
tim-lai
merged 13 commits into
swagger-api:master
from
mathis-m:ft/sample-gen-valiadtion-constraints
Mar 10, 2021
Merged
feat: sample gen should incorporate schema validation constraint #7043
tim-lai
merged 13 commits into
swagger-api:master
from
mathis-m:ft/sample-gen-valiadtion-constraints
Mar 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
mathis-m
changed the title
Ft/sample gen validation constraints
feat: sample gen should should incorporate schema validation constraint
Mar 7, 2021
mathis-m
changed the title
feat: sample gen should should incorporate schema validation constraint
feat: sample gen should incorporate schema validation constraint
Mar 8, 2021
@mathis-m PR merged! Thanks for the contribution! |
This was referenced Mar 12, 2021
This was referenced Mar 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sample-gen should consider validation constraints in order to generate valid samples.
added min / max length
added minimum / maximum (+ exclusive)
added min / max items
added min / max properties
Motivation and Context
Fixes #4388
How Has This Been Tested?
via new tests
Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests