-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods for NotFound and MethodNotAllowed, add response.EmbeddedSetter #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines Of Code
|
Go API Changes# github.com/swaggest/rest/chirouter ## compatible changes (*Wrapper).HandlerFunc: added # github.com/swaggest/rest/response ## compatible changes EmbeddedSetter: added Setter: added # github.com/swaggest/rest/web ## compatible changes (*Service).OnMethodNotAllowed: added (*Service).OnNotFound: added github.com/swaggest/rest/chirouter.(*Wrapper).HandlerFunc: added # summary Inferred base version: v0.2.60 Suggested version: v0.3.0 |
Unit Test Coveragetotal: (statements) 81.2% Coverage of changed lines
Coverage diff with base branch
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
==========================================
+ Coverage 76.00% 76.16% +0.16%
==========================================
Files 30 30
Lines 1700 1712 +12
==========================================
+ Hits 1292 1304 +12
Misses 295 295
Partials 113 113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Benchmark ResultBenchmark diff with base branch
Benchmark result
|
Examples Benchmark ResultBenchmark diff with base branch
|
vearutop
changed the title
Add methods for NotFound and MethodNotAllowed
Add methods for NotFound and MethodNotAllowed, add response.EmbeddedSetter
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.