Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with swaggo/gin-swagger -> github.com/ugorji/go v1.1.5-pre #826

Closed
nickarsar opened this issue Nov 4, 2020 · 9 comments
Closed

Comments

@nickarsar
Copy link

Have problem with go mod download in project using swag:

go: github.com/swaggo/swag@v1.6.9 requires github.com/swaggo/gin-swagger@v1.2.0 requires github.com/ugorji/go@v1.1.5-pre requires github.com/ugorji/go/codec@v1.1.5-pre: reading github.com/ugorji/go/codec/codec/go.mod at revision codec/v1.1.5-pre: unknown revision codec/v1.1.5-pre

This helped me:
replace github.com/swaggo/gin-swagger v1.2.0 => github.com/swaggo/gin-swagger v1.3.0

Related issue: swaggo/gin-swagger#128

@jakesylvestre
Copy link
Contributor

jakesylvestre commented Nov 5, 2020

@nickarsar I fixed this in #825, but no release was made. For now you can use
github.com/swaggo/swag v1.6.10-0.20201104153820-3f47d68f8872

@ubogdan might make sense to release what's on master now

Also, one word of caution on replace that I found out the hardway fixing this. replace doesn't fix downstream modules (e.g. any module that depends on the module using the replace also requires you to manually add the replace). It doesn't look like go plans on changing this behavior any time soon (see golang/go#30354)

@kkontus
Copy link

kkontus commented Nov 19, 2020

Can this thing be fixed in http-swagger as well, please :)?

@stigok
Copy link

stigok commented Nov 20, 2020

This is still an issue! To reproduce

$ mkdir hello
$ cd hello
$ go mod init hello
$ go get github.com/swaggo/swag/cmd/swag
go: found github.com/swaggo/swag/cmd/swag in github.com/swaggo/swag v1.6.9
go get: github.com/swaggo/swag@v1.6.9 requires
	github.com/swaggo/gin-swagger@v1.2.0 requires
	github.com/ugorji/go@v1.1.5-pre requires
	github.com/ugorji/go/codec@v1.1.5-pre: reading github.com/ugorji/go/codec/codec/go.mod at revision codec/v1.1.5-pre: unknown revision codec/v1.1.5-pre

@kkontus
Copy link

kkontus commented Nov 20, 2020

yes, exactly. Shouldn't this be just matter of creating tag v1.1.5-pre or remove dependencies to it?

@jakesylvestre
Copy link
Contributor

Dependencies were removed in 3f47d68, but no release has been made since then. Is the workaround here not working?

@kkontus
Copy link

kkontus commented Nov 21, 2020

@jakesyl oh, I missed that, thank you very much mate, it works 👏

@akojo
Copy link
Contributor

akojo commented Nov 23, 2020

#800 removes dependency on gin-swagger altogether so this should be fixed in the next release

@ghost
Copy link

ghost commented Nov 23, 2020

#800 removes dependency on gin-swagger altogether so this should be fixed in the next release

Removing github.com/ugorji/go as a dependency seems like a smart move. It's forever breaking downstream repos with tags being deleted and go module weirdness.

This issue is currently blocking some of our builds - any ideas when it'll be released? The release is also a blocker for fixing this swaggo/http-swagger#36

Cheers.

sdghchj pushed a commit that referenced this issue Dec 3, 2020
Update gin-swagger dependency version to mitigate issue with missing dep (github.com/ugorji/go v1.1.5-pre).

Issue link: #826

Co-authored-by: Eason Lin <easonlin404@gmail.com>
@ubogdan
Copy link
Contributor

ubogdan commented Sep 28, 2021

Closing: fixed.

@ubogdan ubogdan closed this as completed Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants