Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multipleOf field to parser. #1008

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Add multipleOf field to parser. #1008

merged 2 commits into from
Sep 27, 2021

Conversation

jimmycannlfs
Copy link
Contributor

@jimmycannlfs jimmycannlfs commented Sep 27, 2021

Describe the PR
Add ability to specify multipleOf struct field

Relation issue
N/A


Sorry, ran into an issue and needed to reopen

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #1008 (d87b5ed) into master (0aac069) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d87b5ed differs from pull request most recent head 87996d1. Consider uploading reports for the commit 87996d1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
+ Coverage   93.19%   93.20%   +0.01%     
==========================================
  Files           7        7              
  Lines        1924     1929       +5     
==========================================
+ Hits         1793     1798       +5     
  Misses         73       73              
  Partials       58       58              
Impacted Files Coverage Δ
parser.go 93.38% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aac069...87996d1. Read the comment docs.

@ubogdan
Copy link
Contributor

ubogdan commented Sep 27, 2021

Good job so far. We need a coverage test passing.

@jimmycannlfs
Copy link
Contributor Author

Cool thanks! It's a little hard to tell, but that last commit should cover it :D

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit bcbae0f into swaggo:master Sep 27, 2021
@ubogdan
Copy link
Contributor

ubogdan commented Sep 27, 2021

Thanks for your contribution.

@jimmycannlfs jimmycannlfs deleted the feature/multipleof branch September 27, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants