Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix @x-tagGroups #1010

Merged
merged 2 commits into from
Sep 29, 2021
Merged

fix @x-tagGroups #1010

merged 2 commits into from
Sep 29, 2021

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Sep 28, 2021

Describe the PR
add test for @X-tagGroups

Relation issue
#916

Additional context
NONE

@codecov
Copy link

codecov bot commented Sep 28, 2021 •
edited
Loading

Codecov Report

Merging #1010 (ccd051f) into master (bcbae0f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1010   +/-   ##
=======================================
  Coverage   93.20%   93.21%           
=======================================
  Files           7        7           
  Lines        1929     1931    +2     
=======================================
+ Hits         1798     1800    +2     
  Misses         73       73           
  Partials       58       58
Impacted Files Coverage Δ
parser.go 93.40% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcbae0f...ccd051f. Read the comment docs.

@ubogdan ubogdan changed the title improve unit tests fix @x-tagGroups Sep 28, 2021
sdghchj
sdghchj approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@sdghchj sdghchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdghchj sdghchj merged commit f9645be into master Sep 29, 2021
@sdghchj sdghchj deleted the fix_tagGroup branch September 29, 2021 08:34
@ubogdan ubogdan mentioned this pull request Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdghchj sdghchj sdghchj approved these changes

Assignees

@sdghchj sdghchj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ubogdan @sdghchj