-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto parse external models when flag parseDependency is set #1027
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
- Coverage 93.34% 93.00% -0.34%
==========================================
Files 7 7
Lines 1968 2002 +34
==========================================
+ Hits 1837 1862 +25
- Misses 73 77 +4
- Partials 58 63 +5
Continue to review full report at Codecov.
|
cmd/swag/main.go
Outdated
Usage: "Parse go files in outside dependency folder, disabled by default", | ||
Name: parseDependencyFlag, | ||
Aliases: []string{"pd"}, | ||
Usage: "Parse go files in outside dependency folder, disabled by default", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase suggestion:
"Parse the go files outside the dependency folder, disabled by default."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase suggestion: "Parse the go files outside the dependency folder, disabled by default."
I guess it wants to express parsing the files in the dependency folder outside the current folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should say: "Parse the go files inside dependency folder, disabled by default."
The "in outside" is ambiguous phrasing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe the PR
Auto parse external models when flag parseDependency is set
Relation issue
#808