Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve code quality #1047

Merged
merged 5 commits into from
Nov 10, 2021
Merged

improve code quality #1047

merged 5 commits into from
Nov 10, 2021

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Nov 10, 2021

Describe the PR

  • improve code quality
  • clean some typos
  • align structure data to use less memory

Relation issue
NONE

Additional context
NONE

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1047 (6d4346b) into master (5237c6d) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1047      +/-   ##
==========================================
+ Coverage   93.34%   93.46%   +0.11%     
==========================================
  Files           8        8              
  Lines        2134     2127       -7     
==========================================
- Hits         1992     1988       -4     
+ Misses         79       77       -2     
+ Partials       63       62       -1     
Impacted Files Coverage Δ
swagger.go 100.00% <ø> (ø)
types.go 100.00% <ø> (ø)
field_parser.go 100.00% <100.00%> (+0.67%) ⬆️
gen/gen.go 95.68% <100.00%> (ø)
operation.go 95.00% <100.00%> (+0.03%) ⬆️
packages.go 76.83% <100.00%> (+0.04%) ⬆️
parser.go 92.26% <100.00%> (-0.01%) ⬇️
schema.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5237c6d...6d4346b. Read the comment docs.

@ubogdan ubogdan changed the title refactor improve code quality Nov 10, 2021
@ubogdan ubogdan merged commit 9b23c9e into master Nov 10, 2021
@ubogdan ubogdan deleted the refactor branch November 10, 2021 22:32
Copy link
Contributor

@forsaken628 forsaken628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@ubogdan
Copy link
Contributor Author

ubogdan commented Nov 11, 2021

please comment on the code so I can fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants