Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve code quality #1049

Merged
merged 3 commits into from
Nov 11, 2021
Merged

improve code quality #1049

merged 3 commits into from
Nov 11, 2021

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Nov 11, 2021

Describe the PR

  • refactor field_parser.go
  • refactor operation.go

Relation issue
NONE

Additional context
NONE

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #1049 (f6aeca1) into master (e59f457) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head f6aeca1 differs from pull request most recent head 24a31ae. Consider uploading reports for the commit 24a31ae to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
+ Coverage   93.71%   93.89%   +0.17%     
==========================================
  Files           8        8              
  Lines        2100     2096       -4     
==========================================
  Hits         1968     1968              
+ Misses         70       67       -3     
+ Partials       62       61       -1     
Impacted Files Coverage Δ
field_parser.go 100.00% <100.00%> (ø)
operation.go 95.60% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59f457...24a31ae. Read the comment docs.

@ubogdan ubogdan merged commit 60fc849 into master Nov 11, 2021
@ubogdan ubogdan deleted the refactor branch November 11, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant