Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing panics on default response #1068

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Dec 1, 2021

Describe the PR
fix issue introduced during code refactor

Relation issue
#1067

Additional context
none

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1068 (0f015bc) into master (a7065ad) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
- Coverage   94.22%   94.21%   -0.01%     
==========================================
  Files           9        9              
  Lines        2320     2317       -3     
==========================================
- Hits         2186     2183       -3     
  Misses         70       70              
  Partials       64       64              
Impacted Files Coverage Δ
operation.go 95.88% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7065ad...0f015bc. Read the comment docs.

@ubogdan ubogdan force-pushed the 1067-panic_on_default_response branch from ee32485 to 0f015bc Compare December 1, 2021 09:11
@ubogdan ubogdan merged commit 47d0cd2 into master Dec 1, 2021
@ubogdan ubogdan deleted the 1067-panic_on_default_response branch December 1, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant