Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:remove unnecessary check #1073

Merged
merged 1 commit into from
Dec 10, 2021
Merged

chore:remove unnecessary check #1073

merged 1 commit into from
Dec 10, 2021

Conversation

nmmsantos
Copy link
Contributor

Describe the PR
This will remove the check for existence of the SearchDir on swag fmt which is breaking the comma separated list feature from swag fmt -d cmd/hello,./, fore example.

Relation issue

Additional context
The check is being made after splitting the list on the comma character, later, in the FormatAPI call.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #1073 (f7e9fba) into master (75e9d01) will not change coverage.
The diff coverage is n/a.

❗ Current head f7e9fba differs from pull request most recent head 98750e6. Consider uploading reports for the commit 98750e6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1073   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files           9        9           
  Lines        2310     2310           
=======================================
  Hits         2176     2176           
  Misses         70       70           
  Partials       64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e9d01...98750e6. Read the comment docs.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan changed the title Remove unnecessary check chore:remove unnecessary check Dec 10, 2021
@ubogdan ubogdan merged commit 00a256c into swaggo:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants