Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve code quality #1086

Merged
merged 3 commits into from
Dec 23, 2021
Merged

chore: improve code quality #1086

merged 3 commits into from
Dec 23, 2021

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Dec 23, 2021

Describe the PR
improve code quality

Relation issue
NONE

Additional context
NONE

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1086 (cbe5e29) into master (54c9ff9) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
+ Coverage   94.22%   94.47%   +0.24%     
==========================================
  Files           9        9              
  Lines        2320     2316       -4     
==========================================
+ Hits         2186     2188       +2     
+ Misses         70       67       -3     
+ Partials       64       61       -3     
Impacted Files Coverage Δ
formater.go 100.00% <100.00%> (ø)
operation.go 95.86% <100.00%> (-0.03%) ⬇️
packages.go 83.61% <100.00%> (+3.38%) ⬆️
parser.go 92.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c9ff9...cbe5e29. Read the comment docs.

@ubogdan ubogdan changed the title chore: reduce mem allocations in operation.go chore: improve code quality Dec 23, 2021
@ubogdan ubogdan merged commit f631188 into master Dec 23, 2021
@ubogdan ubogdan deleted the reduce_boilerplate branch December 23, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant