-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: swaggerinfo template for instanceNames #1134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Syuparn Would you mind adding a unit test for template rendering output to cover this fix? |
Codecov Report
@@ Coverage Diff @@
## master #1134 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 10 10
Lines 2433 2433
=======================================
Hits 2305 2305
Misses 67 67
Partials 61 61
Continue to review full report at Codecov.
|
c354d8b
to
9b56776
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Syuparn Thanks for your contribution |
Describe the PR
e.g. fix template to generate swaggerInfo variable when
--instanceName
option is specifiedRelation issue
#1133