-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/security or #1158
Feature/security or #1158
Conversation
Lehp
commented
Mar 10, 2022
•
edited
Loading
edited
- remove unnecessary comment,
- add or-functionality to parser_test
@ubogdan I added or to the general check. How can i use this functionality locally? I tried using the master branch and i saw my code in the vendor-folder, but it didn't work. |
This reverts commit e163c2d.
Codecov Report
@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
+ Coverage 94.73% 94.76% +0.02%
==========================================
Files 10 10
Lines 2433 2443 +10
==========================================
+ Hits 2305 2315 +10
Misses 67 67
Partials 61 61
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ubogdan Hey ubogdan I've been looking atleast 5h for the reason my code doesn't work. Everything executes fine. Every tests is ok. But in the End the file does not contain the object parseSecurityComment returns. Could you give me a hint? I don't know where to search anymore. The input comment seen in a Test: |
It's quite late on my end... Try yo move the declaration |
@ubogdan |