-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to specify multiple routes for the same function #957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the 2 comments left LTGTM.
Before we merge this into master we need to document the feature in README.md so all our users will be aware of it. |
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
==========================================
+ Coverage 84.83% 86.04% +1.20%
==========================================
Files 8 8
Lines 1649 1835 +186
==========================================
+ Hits 1399 1579 +180
- Misses 145 150 +5
- Partials 105 106 +1
Continue to review full report at Codecov.
|
Have updated the readme with an example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution! |
Describe the PR
Add support to specify multiple routes for the same function
Relation issue
#460
Additional context
In the case of multiple @router comments, swagger creates routes using information only from the last comment.
This change would help us add swagger routes for each comment.