Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage and code readability. #967

Merged
merged 5 commits into from
Aug 4, 2021

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Aug 3, 2021

Describe the PR
Improve test coverage and code readability.

Relation issue
#921 - this issue reduced the code coverage after merging .

CI didn't work for some reason and there was no CodeCove report.

Additional context
NONE

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #967 (80fbff7) into master (f2f643a) will increase coverage by 1.81%.
The diff coverage is 93.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
+ Coverage   86.04%   87.86%   +1.81%     
==========================================
  Files           8        8              
  Lines        1835     1829       -6     
==========================================
+ Hits         1579     1607      +28     
+ Misses        150      127      -23     
+ Partials      106       95      -11     
Impacted Files Coverage Δ
operation.go 89.60% <90.00%> (+0.87%) ⬆️
parser.go 86.33% <94.11%> (+3.01%) ⬆️
packages.go 74.38% <100.00%> (+1.04%) ⬆️
schema.go 100.00% <100.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f643a...80fbff7. Read the comment docs.

@ubogdan ubogdan changed the title add unit tests for schema.go Improve test coverage and code readability. Aug 3, 2021
@ubogdan ubogdan requested review from easonlin404 and sdghchj August 4, 2021 10:08
@sdghchj
Copy link
Member

sdghchj commented Aug 4, 2021

Reviewed

@ubogdan
Copy link
Contributor Author

ubogdan commented Aug 4, 2021

Reviewed

Thanks.

@ubogdan ubogdan merged commit cb2bdb6 into master Aug 4, 2021
@ubogdan ubogdan deleted the refactor_and_coverage_improvements branch August 4, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants