Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor and lint code #978

Merged
merged 9 commits into from
Aug 15, 2021
Merged

refactor and lint code #978

merged 9 commits into from
Aug 15, 2021

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Aug 13, 2021

Describe the PR

  • reduce code complexity
  • improve code testing and coverage

Relation issue
NONE

Additional context
NONE

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #978 (04c12f5) into master (b19e9cf) will increase coverage by 2.41%.
The diff coverage is 94.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
+ Coverage   88.15%   90.57%   +2.41%     
==========================================
  Files           8        8              
  Lines        1874     1909      +35     
==========================================
+ Hits         1652     1729      +77     
+ Misses        127      104      -23     
+ Partials       95       76      -19     
Impacted Files Coverage Δ
swagger.go 100.00% <ø> (ø)
types.go 100.00% <ø> (ø)
packages.go 77.55% <81.25%> (+0.85%) ⬆️
parser.go 89.32% <96.01%> (+2.50%) ⬆️
operation.go 92.89% <96.77%> (+3.28%) ⬆️
debug.go 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b19e9cf...04c12f5. Read the comment docs.

@ubogdan ubogdan requested review from easonlin404 and sdghchj and removed request for easonlin404 August 13, 2021 22:47
@ubogdan
Copy link
Contributor Author

ubogdan commented Aug 13, 2021

@sdghchj Need a review, please.

Copy link
Member

@sdghchj sdghchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdghchj sdghchj merged commit fd74bcf into master Aug 15, 2021
@sdghchj sdghchj deleted the code_cleanup branch August 15, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants