-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug info should go to stdout instead of stderr #990
Conversation
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
==========================================
+ Coverage 92.57% 93.19% +0.61%
==========================================
Files 8 7 -1
Lines 1925 1924 -1
==========================================
+ Hits 1782 1793 +11
+ Misses 80 73 -7
+ Partials 63 58 -5
Continue to review full report at Codecov.
|
a CR will be much appreciated. 10x |
@easonlin404 should we forget about this feature? |
@sdghchj can you please give me a hand with a CR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you. |
Describe the PR
add support to set up a logger for the parser. The default one should write to stdout instead of stderr.
Relation issue
#929
Additional context
NONE