Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug info should go to stdout instead of stderr #990

Merged
merged 5 commits into from
Sep 23, 2021

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Aug 31, 2021

Describe the PR
add support to set up a logger for the parser. The default one should write to stdout instead of stderr.

Relation issue
#929

Additional context
NONE

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #990 (c49b897) into master (642f320) will increase coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #990      +/-   ##
==========================================
+ Coverage   92.57%   93.19%   +0.61%     
==========================================
  Files           8        7       -1     
  Lines        1925     1924       -1     
==========================================
+ Hits         1782     1793      +11     
+ Misses         80       73       -7     
+ Partials       63       58       -5     
Impacted Files Coverage Δ
operation.go 95.10% <100.00%> (+0.84%) ⬆️
parser.go 93.35% <100.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 642f320...c49b897. Read the comment docs.

@ubogdan ubogdan requested a review from sdghchj August 31, 2021 20:51
@ubogdan ubogdan requested review from easonlin404, pei0804 and sdghchj and removed request for sdghchj September 6, 2021 08:17
@ubogdan
Copy link
Contributor Author

ubogdan commented Sep 8, 2021

a CR will be much appreciated. 10x

@ubogdan
Copy link
Contributor Author

ubogdan commented Sep 14, 2021

@easonlin404 should we forget about this feature?

@ubogdan
Copy link
Contributor Author

ubogdan commented Sep 22, 2021

@sdghchj can you please give me a hand with a CR.

Copy link
Member

@sdghchj sdghchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdghchj sdghchj merged commit a76cfa3 into master Sep 23, 2021
@sdghchj sdghchj deleted the debug_info_to_stdout branch September 23, 2021 01:15
@ubogdan
Copy link
Contributor Author

ubogdan commented Sep 23, 2021

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants