Merge pull request #79 from nobrayner/fix-78

Fix 78: Serializer.encode throws for null and undefined
swan-io · Aug 29, 2024 · 2129b74 · 2129b74
2 parents 328f9d3 + d9e3483
commit 2129b74
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/Serializer.ts b/src/Serializer.ts
@@ -6,6 +6,9 @@ export const encode = (value: any, indent?: number | undefined) => {
   return JSON.stringify(
     value,
     (key, value) => {
+      if (value == null) {
+        return value;
+      }
       if (typeof value[BOXED_TYPE] === "string") {
         return { ...value, __boxed_type__: value[BOXED_TYPE] };
       }

diff --git a/test/Serializer.test.ts b/test/Serializer.test.ts
@@ -12,6 +12,13 @@ test("Serializer", () => {
           nothing: Option.None(),
           loading: AsyncData.Loading(),
           notAsked: AsyncData.NotAsked(),
+          nullable: null,
+          undefinable: undefined,
+          string: "Hello",
+          number: 1209,
+          boolean: true,
+          array: [1, 2, 3],
+          object: { a: 1, b: "two" },
         }),
       ),
     ),
@@ -22,4 +29,6 @@ test("Serializer", () => {
   expect(decode(encode(start)).value.map(() => "Hello")).toEqual(
     AsyncData.Done("Hello"),
   );
+  expect(encode(null)).toEqual("null");
+  expect(encode(undefined)).toEqual(undefined);
 });