Feedback german onboarding (#898)

* Feedback german onboarding * Nit add missing word * Fix birthdate type * Fix birthdate typing * Fix
swan-io · Sep 11, 2024 · 01028a8 · 01028a8
1 parent 495b417
commit 01028a8
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 17 deletions.
diff --git a/clients/banking/package.json b/clients/banking/package.json
@@ -17,9 +17,9 @@
  "@swan-io/boxed": "2.3.0",
  "@swan-io/chicane": "2.1.0",
  "@swan-io/graphql-client": "0.2.1",
- "@swan-io/lake": "8.14.6",
+ "@swan-io/lake": "8.14.7",
  "@swan-io/request": "1.0.6",
- "@swan-io/shared-business": "8.14.6",
+ "@swan-io/shared-business": "8.14.7",
  "@swan-io/use-form": "2.0.5",
  "core-js": "3.37.1",
  "dayjs": "1.11.12",

diff --git a/clients/banking/src/locales/en.json b/clients/banking/src/locales/en.json
@@ -499,7 +499,7 @@
  "merchantProfile.request.accentColor.label": "Accent color",
  "merchantProfile.request.expectedAverageBasket.label": "Expected average transaction",
  "merchantProfile.request.expectedMonthlyPaymentVolume.label": "Expected monthly payment volume",
- "merchantProfile.request.id": "Merchant ID",
+ "merchantProfile.request.id": "Merchant profile ID",
  "merchantProfile.request.merchantLogo.acceptedImageUpload": "PNG, max 1MB",
  "merchantProfile.request.merchantLogo.label": "Merchant logo",
  "merchantProfile.request.merchantName.label": "Merchant name",

diff --git a/clients/onboarding/package.json b/clients/onboarding/package.json
@@ -17,9 +17,9 @@
  "@swan-io/boxed": "2.3.0",
  "@swan-io/chicane": "2.1.0",
  "@swan-io/graphql-client": "0.2.1",
- "@swan-io/lake": "8.14.6",
+ "@swan-io/lake": "8.14.7",
  "@swan-io/request": "1.0.6",
- "@swan-io/shared-business": "8.14.6",
+ "@swan-io/shared-business": "8.14.7",
  "@swan-io/use-form": "2.0.5",
  "core-js": "3.37.1",
  "dayjs": "1.11.12",

diff --git a/...c/pages/company/ownership-beneficiary/OnboardingCompanyOwnershipBeneficiaryFormCommon.tsx b/...c/pages/company/ownership-beneficiary/OnboardingCompanyOwnershipBeneficiaryFormCommon.tsx
@@ -160,7 +160,6 @@ export const OnboardingCompanyOwnershipBeneficiaryFormCommon = forwardRef<
  const requiredFields = Option.allFromDict({
  firstName,
  lastName,
- birthDate: birthDate.flatMap(Option.fromNullable),
  birthCountryCode,
  birthCity,
  birthCityPostalCode,
@@ -185,14 +184,18 @@ export const OnboardingCompanyOwnershipBeneficiaryFormCommon = forwardRef<
 
  return onSave({
  ...requiredFields.get(),
+ birthDate: birthDate.flatMap(Option.fromNullable).toNull(),
  direct,
  indirect,
  totalCapitalPercentage: Number(totalCapitalPercentage),
  });
  },
  )
  .with({ requiredFields: Option.P.Some(P.any) }, ({ requiredFields }) => {
- return onSave(requiredFields.get());
+ return onSave({
+ ...requiredFields.get(),
+ birthDate: birthDate.flatMap(Option.fromNullable).toNull(),
+ });
  })
  .otherwise(() => {});
  },
@@ -249,6 +252,7 @@ export const OnboardingCompanyOwnershipBeneficiaryFormCommon = forwardRef<
  <Field name="birthDate">
  {({ value, onChange, error }) => (
  <BirthdatePicker
+ style={styles.inputContainer}
  label={t("company.step.owners.beneficiary.birthDate")}
  value={value}
  onValueChange={onChange}

diff --git a/clients/payment/package.json b/clients/payment/package.json
@@ -17,8 +17,8 @@
  "@swan-io/boxed": "2.3.0",
  "@swan-io/chicane": "2.1.0",
  "@swan-io/graphql-client": "0.2.1",
- "@swan-io/lake": "8.14.6",
- "@swan-io/shared-business": "8.14.6",
+ "@swan-io/lake": "8.14.7",
+ "@swan-io/shared-business": "8.14.7",
  "@swan-io/use-form": "2.0.5",
  "core-js": "3.37.1",
  "dayjs": "1.11.12",

diff --git a/yarn.lock b/yarn.lock
@@ -2123,10 +2123,10 @@
  "@swan-io/request" "^1.0.6"
  ts-pattern "^5.1.0"
 
-"@swan-io/lake@8.14.6":
- version "8.14.6"
- resolved "https://registry.yarnpkg.com/@swan-io/lake/-/lake-8.14.6.tgz#5d1eb15b4b3a22df52e2823cf094b1a9b7ee61fe"
- integrity sha512-K0boUOn0iJWWlpt89sINEB8YJwF9ec8h77pFxs+9QVQ7sjFwJBLJ89VzU+t+6CdMmYSTgSH7JN0haYf+j+9NPQ==
+"@swan-io/lake@8.14.7":
+ version "8.14.7"
+ resolved "https://registry.yarnpkg.com/@swan-io/lake/-/lake-8.14.7.tgz#eb34158a4fcde150617d5e176b83142ba208a688"
+ integrity sha512-srBn2zJwBgY55yoCqWXCDXj1DeT74gVse8sRSX4WEUyua1nUqTq86tM8l38MET+icPMKNvGU9AAPNEcKSoDzew==
  dependencies:
  "@react-three/drei" "^9.109.2"
  "@react-three/fiber" "^8.16.8"
@@ -2151,10 +2151,10 @@
  resolved "https://registry.yarnpkg.com/@swan-io/request/-/request-1.0.6.tgz#e46c7a92d4088a484bfd60e180bd2768adb68568"
  integrity sha512-HirhY0gu6aZk95YGXONcmwrfwQ0u5+uZGAtwtSDmrXfCLEGubXb1qIdRMex1e65TroXnTzBG3A65M5EvUB28ZQ==
 
-"@swan-io/shared-business@8.14.6":
- version "8.14.6"
- resolved "https://registry.yarnpkg.com/@swan-io/shared-business/-/shared-business-8.14.6.tgz#bde7e23db84ee575d4e98f3e4480f25ea8f65ad1"
- integrity sha512-VQw0a5kcRZtwyVmE0Flvlbdq4MML19xHqu/d7wvTNKGJkCAukEKyR6NdK6cpTort1OvAZSHjTdz6Pe01/XLxag==
+"@swan-io/shared-business@8.14.7":
+ version "8.14.7"
+ resolved "https://registry.yarnpkg.com/@swan-io/shared-business/-/shared-business-8.14.7.tgz#c9684ae8a597ab22ef744e012fd04184ceff6ea2"
+ integrity sha512-UUNJOPnXnoeg0/iwLToFAIbRbWGs2zJkFKkRQSD1taiZfhKNn2ZFBTCZgyLupMol++W3kwjsXcyquAId7yxlDg==
  dependencies:
  "@formatjs/intl" "^2.10.4"
  "@placekit/client-js" "^2.3.0"