Change config_files type to Iterable and add tests #167
+28
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a situation where I have a non-list of config files. Looking at the source, any
Sequence
and evenIterable
should be ok as they are instantly consumed.This PR changes the type of
config_files: list[PathLike]
toconfig_files: Iterable[PathLike]
.Furthermore chaning the type (to at least Sequence) does not raise type errors for users when they pass a pure list to
config_files
: