added ping module #30
Conversation
|
Can we leverage an API call for this? |
|
You mean like pyping? It requires root on linux machines. I'll check it in a week because from today it's vacation time :) |
|
|
||
| return output | ||
|
|
||
| ping_str = "-n 1" if platform.system().lower() == "windows" else "-c 1" |
There was a problem hiding this comment.
this platform thing is bugging me!
|
Keeping in mind that it should be cross-platform compatible, we have two options: either use a python library (sockets / requests) to check website availability, or use an external service like |
|
Hey @sasek333, will you be willing to complete this? 😄 |
|
Actually @swapagarwal something's been bothering me for a while. The only use of ping module is to check if the internet connection is working or not. And this condition is already satisfied when we are using messenger right? because it's only then we can use messenger right? Am I missing something or is there something else to it? |
|
@shanmukhateja Well, this would check whether a website can be reached or not, say is github.com down or not? |
|
Oh OK so it was meant for another website's working state. Good :) |
|
@swapagarwal :If the intention is just to check whether a website is up or down, then we can request for the page from our host server if it returns a response then it is up right else if it times out for say continuously three packets then it must be down. This way I guess cross compatibility will be maintained and purpose will also be served. If any other use case comes to your mind for which the above does not cover let me know. |
|
@VarunWachaspati Yes, we can implement this on our server itself, but that adds to the maintenance cost! |
|
May I take this up? How about implementing this using isitup.org to check whether a website is down or not? |
|
Added in #197 |
requires os's ping access