-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add applause button #124
Add applause button #124
Conversation
In my opinion the applause button is too big. It looks a bit out of place. I think maybe it should be the same size as the difficulty indicator circle (which could be enlarged slightly too) |
@zac-garby Agreed - only difficulty is that the numbers start to overlap with the button at anything below 42px. I'll try bumping up the size of the difficulty indicator and we'll see if that makes it any better. |
This looks great! There were two things that came to mind:
|
Thanks @andrewda for picking this up! 🎉 A weird bug: Clap 10 items for an item and reload the page. The last clap isn't persisted. 🤔 On an unrelated note, should we restrict the user to one clap per item? |
👍 for limiting to one clap |
site/src/pug/includes/head.pug
Outdated
@@ -14,6 +14,9 @@ link(rel="apple-touch-icon" size="128x128" href="/assets/img/logo.png") | |||
link(rel="stylesheet" href="/assets/css/index.css") | |||
link(rel="stylesheet" href="https://fonts.googleapis.com/css?family=Cabin") | |||
|
|||
link(rel="stylesheet" href="https://unpkg.com/applause-button/dist/applause-button.css") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo Selectr is more important than applause so it should be loaded before applause
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this link & script have to be moved to the end of the body (link staying before the script tag).
<link rel="stylesheet">
is allowed in the body: https://html.spec.whatwg.org/multipage/links.html#body-ok
@plibither8 @andrewda A solution (for the first point you rose) would be to use the actual reference url instead of |
Good idea @aslafy-z! |
requestClaps(urls).then(resp => { | ||
claps = resp; | ||
|
||
const selectInput = document.getElementById('sorting'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete this line since sortingInput
is a global with the same value
@andrewda Can you rebase this on master? |
Pinging @andrewda |
This adds an applause button to allow users to vote on their favorite swag!
Closes #104
Still TODO