Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safety Manual Added #361

Closed
wants to merge 2 commits into from

Conversation

anushka1309paul
Copy link

Fixes: #230

Description:
Added Women's Safety tips with all required changes.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.

@anushka1309paul
Copy link
Author

Kindly check if it is fixed.

@swapnilsparsh
Copy link
Owner

@anushka1309paul Same error.

@anushka1309paul
Copy link
Author

Kindly send me the error message as I cannot find it.

@swapnilsparsh
Copy link
Owner

120079934-fcfcf200-c0d3-11eb-93de-aa4dadb528ec

@anushka1309paul
Copy link
Author

I am getting no such error. It must be on your end.

@anushka1309paul
Copy link
Author

Maybe if you run the check I can know what the error is.

Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Align the Questions heading in the center.
  2. Remove Expert say from the answer.
  3. Reduce the size of the photo and get it aligned with the heading.

@anushka1309paul
Copy link
Author

If you do not wish to merge this Pull Request kindly say so and then I'll close the issue.

@anushka1309paul
Copy link
Author

If not, please merge it first, then I shall make another commit with the changes.

@anushka1309paul
Copy link
Author

The error that is being shown in the checks is nowhere to be found, kindly look into it. Furthermore, I've been assigned to this task for 2 months now and every single time I've made the requested "final" changes in a single page at that, new changes have been requested each time, which could have easily been pointed out in the very beginning. It is really disappointing to see such a response to the commit I am trying to make but it seems as though this issue is not required in the project at all. If that is the case, I do not wish to spend any more time making unnecessary changes when there is no intention to include this section in the project that in my opinion was unique and empowering when I started to work on it.
A little more clarity regarding this would have been appreciated.

@swapnilsparsh
Copy link
Owner

The error that is being shown in the checks is nowhere to be found, kindly look into it. Furthermore, I've been assigned to this task for 2 months now and every single time I've made the requested "final" changes in a single page at that, new changes have been requested each time, which could have easily been pointed out in the very beginning. It is really disappointing to see such a response to the commit I am trying to make but it seems as though this issue is not required in the project at all. If that is the case, I do not wish to spend any more time making unnecessary changes when there is no intention to include this section in the project that in my opinion was unique and empowering when I started to work on it.
A little more clarity regarding this would have been appreciated.

Sorry for the inconvenience caused.
There is no intention that we don't want to merge your PR but each and every time there are some issues that arise up.
Please resolve the issues which I have mentioned and then I will be merging your PR.

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Thank you @anushka1309paul for your contribution. Looking forward for more such amazing contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safety Manual Page
2 participants