Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bip32 from 2.0.6 to 3.0.0 #4897

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 11, 2021

Bumps bip32 from 2.0.6 to 3.0.0.

Commits
  • e863a18 3.0.0
  • 5db8c78 Merge pull request #51 from bitcoinjs/dependabot/npm_and_yarn/ansi-regex-5.0.1
  • 902521e Merge pull request #49 from bitcoinjs/dependabot/npm_and_yarn/path-parse-1.0.7
  • 6eec547 Merge pull request #48 from bitcoinjs/dependabot/npm_and_yarn/lodash-4.17.21
  • 3e3619f Merge pull request #52 from bitcoinjs/feature/schnorr
  • e9806c0 Simple sanity check on wrap
  • c8dfd2c Add schnorr signing and verification
  • 0a07dae Bump ansi-regex from 5.0.0 to 5.0.1
  • f6b9b5b Merge pull request #50 from bitcoinjs/feature/modular
  • 69653eb Make bip32 require an ecc library be passed in
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [bip32](https://github.com/bitcoinjs/bip32) from 2.0.6 to 3.0.0.
- [Release notes](https://github.com/bitcoinjs/bip32/releases)
- [Commits](bitcoinjs/bip32@v2.0.6...v3.0.0)

---
updated-dependencies:
- dependency-name: bip32
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 11, 2021
@VitaliyShulik
Copy link
Member

VitaliyShulik commented Nov 12, 2021

В общем здесь добавили .wasm файл в новой необходимой зависимости tiny-secp256k1 в пакет и для него нужно активировать в webpack конфиге experiments.asyncWebAssembly, чтобы вообще приложение грузилось, но при обновлении страницы приложение почему-то фризится

в итоге не знаю что делать с этим, получается нужно все связанное с загрузкой приложения переводить в async/await, особенно муторно с createSwapApp

@Disti4ct
Copy link
Collaborator

В общем здесь добавили .wasm файл в новой необходимой зависимости tiny-secp256k1 в пакет и для него нужно активировать в webpack конфиге experiments.asyncWebAssembly, чтобы вообще приложение грузилось, но при обновлении страницы приложение почему-то фризится

в итоге не знаю что делать с этим, получается нужно все связанное с загрузкой приложения переводить в async/await, особенно муторно с createSwapApp

значит в этом обновлении какой то асинхрон, который нужно ждать?

@VitaliyShulik
Copy link
Member

значит в этом обновлении какой то асинхрон, который нужно ждать?

да, у них раньше все на c++ вроде было и норм билдилось синхронно, а сейчас web assembly популярность набирает - видимо решили переписать, но webpack его только тестит

@Disti4ct Disti4ct added the challenge Heroes wanted label Nov 12, 2021
@VitaliyShulik
Copy link
Member

#4898 связаны

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 17, 2021

A newer version of bip32 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenge Heroes wanted dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants