Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: swap with 0x #5219

Closed
wants to merge 2 commits into from
Closed

Fix: swap with 0x #5219

wants to merge 2 commits into from

Conversation

Disti4ct
Copy link
Collaborator

@Disti4ct Disti4ct commented Sep 5, 2023

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the work on the Testnet
  • I checked the work on the Mainnet
  • I checked the work in the plugin
  • I checked the PR once again

Tests

Please start auto tests as follows:

  • add a label swap test to start swap tests
  • add a label withdraw test to start withdraw tests

You can skip these tests if you completely sure that your changes aren't related to this functional

Original issue

#5211

Video / screenshot proof

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a1f2901
Status: ✅  Deploy successful!
Preview URL: https://51e08260.multicurrencywallet-btg.pages.dev
Branch Preview URL: https://fix-0x-interaction.multicurrencywallet-btg.pages.dev

View logs

@noxonsu
Copy link
Member

noxonsu commented Oct 24, 2023

401 отдает сейчас , вставь свой ключ по дефолту
image

@Disti4ct
Copy link
Collaborator Author

Recreated in #5237

@Disti4ct Disti4ct closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants