Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : QuickExchange - UniSwap v3 Support #5244

Open
wants to merge 60 commits into
base: master
Choose a base branch
from
Open

WIP : QuickExchange - UniSwap v3 Support #5244

wants to merge 60 commits into from

Conversation

shendel
Copy link
Collaborator

@shendel shendel commented Jul 26, 2024

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the work on the Testnet
  • I checked the work on the Mainnet
  • I checked the work in the plugin
  • I checked the PR once again

Tests

Please start auto tests as follows:

  • add a label swap test to start swap tests
  • add a label withdraw test to start withdraw tests

You can skip these tests if you completely sure that your changes aren't related to this functional

Original issue

Video / screenshot proof

Copy link

cloudflare-workers-and-pages bot commented Jul 26, 2024

Deploying multicurrencywallet with  Cloudflare Pages  Cloudflare Pages

Latest commit: a273419
Status:🚫  Build failed.

View logs

Copy link

@beage666 beage666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants