Added formats for "empty" and "year" #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert.equal(tr(TEST_OBJECT, TEST_NOT_EMPTY_FIELD_TRUE), true); | ||
| assert.equal(tr(TEST_OBJECT, TEST_NOT_EMPTY_FIELD_FALSE), false); | ||
| }); | ||
| it('should return true/false when a test field is empty', function () { |
There was a problem hiding this comment.
Does this also work if emptyField: null/false/0?
What if emptyField isn't defined?
There was a problem hiding this comment.
emptyField is an arbitrary test field. If empty is not defined, the test will not be triggered.
| return testValue is objectValue | ||
| objectValue = JSON.stringify(objectValue) # match in stringified arrays and objects too | ||
| re = RegExp testValue, "im" | ||
| match = re.test objectValue |
There was a problem hiding this comment.
just do return re.test objectValue no need to store match and return it right after
| return (objectValue is null) or (objectValue is 0) or (objectValue.length is 0) or (Object.keys(objectValue).length is 0) | ||
|
|
||
| else #return true if objectValue is not empty | ||
| return not ((objectValue is null) or (objectValue is 0) or (objectValue.length is 0) or (Object.keys(objectValue).length is 0)) |
There was a problem hiding this comment.
You can merge this and the above if statment by doing checking if isEmpty. Then return if shouldBeEmpty return isEmpty else return not isEmpty
swarajban
added a commit
that referenced
this pull request
Feb 21, 2015
Added formats for "empty" and "year"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.