Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement announcement rendering for Goal completion #1044

Open
kostmo opened this issue Jan 25, 2023 · 3 comments
Open

Implement announcement rendering for Goal completion #1044

kostmo opened this issue Jan 25, 2023 · 3 comments
Assignees
@kostmo
Labels
C-Moderate Effort Should take a moderate amount of time to address. G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-UI Involves the user interface. Z-Feature A new feature to be added to the game.

Comments

@kostmo
Copy link
Member

kostmo commented Jan 25, 2023

Stubs for this functionality were added in #927.

May dovetail with #916.
@kostmo kostmo added the Z-Feature A new feature to be added to the game. label Jan 25, 2023
@kostmo kostmo self-assigned this Jan 25, 2023
@xsebek
Copy link
Member

xsebek commented Jan 25, 2023

I am not sure what this means, but I look forward to it. 🙂

@xsebek
Copy link
Member

xsebek commented Jan 31, 2023

OK, so I just encountered the "stub" while working on #1043:

swarm/src/Swarm/Game/Scenario/Objective/Presentation/Model.hs

Lines 43 to 46 in b80503f

-- | TODO: #1044 Could also add an "ObjectiveFailed" constructor...
newtype Announcement
= ObjectiveCompleted Objective
deriving (Show, Generic, ToJSON)

Personally, I would be fine with a simple flag for notification about Goal completion/failure. That is what the announcementQueue currently does I think.

@kostmo what sort of use do you have in mind for the announcement? Do you want to animate changed goals or maybe select the one that the player should focus on next?

@kostmo kostmo added the T-UI Involves the user interface. label May 30, 2023
@byorgey byorgey added C-Moderate Effort Should take a moderate amount of time to address. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. labels May 20, 2024
@byorgey
Copy link
Member

byorgey commented Nov 11, 2024

Currently, completing or failing a goal causes the goals dialog to pop up, right? What would be the benefit of also generating a notification?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostmo kostmo

Labels
C-Moderate Effort Should take a moderate amount of time to address. G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-UI Involves the user interface. Z-Feature A new feature to be added to the game.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kostmo @byorgey @xsebek